Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 11, 2025

What do these changes do?

ReDoc

Small refactoring of ui schemas of the web-api following #7204

  • ♻️ project_ui models are not domain but schema models -> moved to packages/models-library/src/models_library/api_schemas_webserver
  • ♻️ minor typos in OAS generation

Related issue/s

How to test

in place

@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:models-library labels Feb 11, 2025
@pcrespov pcrespov self-assigned this Feb 11, 2025
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (c04a389) to head (ecacac0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7210      +/-   ##
==========================================
+ Coverage   87.01%   88.25%   +1.23%     
==========================================
  Files        1649     1328     -321     
  Lines       64371    55168    -9203     
  Branches     1095      476     -619     
==========================================
- Hits        56013    48688    -7325     
+ Misses       8045     6351    -1694     
+ Partials      313      129     -184     
Flag Coverage Δ
integrationtests 65.33% <100.00%> (+0.01%) ⬆️
unittests 87.08% <100.00%> (+1.07%) ⬆️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.53% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <100.00%> (-0.01%) ⬇️
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.29% <ø> (-0.02%) ⬇️
dynamic_scheduler 97.19% <ø> (ø)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.11% <ø> (+0.05%) ⬆️
storage 86.34% <ø> (+0.05%) ⬆️
webclient ∅ <ø> (∅)
webserver 84.79% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04a389...ecacac0. Read the comment docs.

@pcrespov pcrespov changed the title WIP: ♻️ Is7158/projects icon extra WIP: ♻️ refactors web-api project's ui schemas Feb 11, 2025
@pcrespov pcrespov added this to the Singularity milestone Feb 11, 2025
@pcrespov pcrespov marked this pull request as ready for review February 11, 2025 13:10
@pcrespov pcrespov changed the title WIP: ♻️ refactors web-api project's ui schemas ♻️ refactors web-api project's ui schemas Feb 11, 2025
@pcrespov pcrespov enabled auto-merge (squash) February 11, 2025 13:11
@pcrespov pcrespov force-pushed the is7158/projects-icon-extra branch from e526d2a to 1085c76 Compare February 11, 2025 16:04
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pcrespov pcrespov disabled auto-merge February 12, 2025 12:00
@pcrespov pcrespov merged commit dd342a3 into ITISFoundation:master Feb 12, 2025
39 checks passed
@sonarqubecloud
Copy link

@pcrespov pcrespov deleted the is7158/projects-icon-extra branch February 12, 2025 12:01
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:models-library a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants