-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 itis vip syncer: adds periodicity in config ⚠️🚨 #7221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 itis vip syncer: adds periodicity in config ⚠️🚨 #7221
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7221 +/- ##
==========================================
+ Coverage 87.04% 87.07% +0.02%
==========================================
Files 1657 1650 -7
Lines 64516 64326 -190
Branches 1095 1095
==========================================
- Hits 56159 56011 -148
+ Misses 8044 8002 -42
Partials 313 313
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Ah just read your explanation :DLICENSES_ITIS_VIP_SYNCER_PERIODICITY defines how often does the syncer runs synchronization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you only needed 1 MR since you are adding a new env var.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is a new ENV variable. Why do you have multiple MRs for the config?? there should be only one.
@sanderegg you are right, these MRs are to introduce the new env-vars that get captured within |
|
|



What do these changes do?
Syncing periodicity of the itis vip licenced resources can be configured via
LICENSES_ITIS_VIP_SYNCER_PERIODICITYRelated issue/s
licensed_itemstable #7097.How to test
Dev-ops
WEBSERVER_LICENSEenv-vars in each deploy: