Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 12, 2025

What do these changes do?

Syncing periodicity of the itis vip licenced resources can be configured via LICENSES_ITIS_VIP_SYNCER_PERIODICITY

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -v tests/unit -k test_itis_vip_syncer_settings

Dev-ops

  • ⚠️ osparc config MRs provide correct configurations for WEBSERVER_LICENSE env-vars in each deploy:
  • please check when merged
  • 🚨 after first sync, make sure that the necessary licensed item resources are activated (i.e. assigned to product and pricing plane)

@pcrespov pcrespov self-assigned this Feb 12, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Feb 12, 2025
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (e35a13f) to head (1430788).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7221      +/-   ##
==========================================
+ Coverage   87.04%   87.07%   +0.02%     
==========================================
  Files        1657     1650       -7     
  Lines       64516    64326     -190     
  Branches     1095     1095              
==========================================
- Hits        56159    56011     -148     
+ Misses       8044     8002      -42     
  Partials      313      313              
Flag Coverage Δ
integrationtests 65.31% <ø> (-0.01%) ⬇️
unittests 86.06% <ø> (+0.02%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.58% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.28% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.48% <ø> (ø)
pkg_settings_library 90.61% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.56% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.68% <ø> (+0.09%) ⬆️
director_v2 91.26% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.08% <ø> (-0.11%) ⬇️
storage 86.22% <ø> (-0.06%) ⬇️
webclient ∅ <ø> (∅)
webserver 84.84% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35a13f...1430788. Read the comment docs.

@pcrespov pcrespov added this to the Singularity milestone Feb 12, 2025
@pcrespov pcrespov marked this pull request as ready for review February 12, 2025 17:14
@pcrespov pcrespov enabled auto-merge (squash) February 12, 2025 17:14
@pcrespov pcrespov changed the title 🎨 itis vip syncer: adds periodicity in config 🎨 itis vip syncer: adds periodicity in config ⚠️🚨 Feb 12, 2025
@pcrespov pcrespov requested review from mguidon and odeimaiz February 12, 2025 17:15
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: LICENSES_ITIS_VIP_SYNCER_PERIODICITY defines how often does the syncer runs synchronization? Ah just read your explanation :D

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you only needed 1 MR since you are adding a new env var.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is a new ENV variable. Why do you have multiple MRs for the config?? there should be only one.

@pcrespov
Copy link
Member Author

pcrespov commented Feb 13, 2025

if this is a new ENV variable. Why do you have multiple MRs for the config?? there should be only one.

@sanderegg you are right, these MRs are to introduce the new env-vars that get captured within WEBSERVER_LICENSE. I prepared branches for every deploy because WEBSERVER_LICENSE is not backwards compatible (it was a bool and now is an object). I changed the explanation in the description

@pcrespov pcrespov disabled auto-merge February 13, 2025 10:35
@pcrespov pcrespov enabled auto-merge (squash) February 13, 2025 12:51
@pcrespov pcrespov disabled auto-merge February 13, 2025 12:52
@pcrespov pcrespov enabled auto-merge (squash) February 13, 2025 13:43
@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit c6b7aff into ITISFoundation:master Feb 13, 2025
92 of 95 checks passed
@pcrespov pcrespov deleted the is7097/licensed-items-envs branch February 13, 2025 16:53
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
@pcrespov
Copy link
Member Author

pcrespov commented Mar 6, 2025

mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants