-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ Refactor webserver projects: drops request dependency on service layer functions
#7228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor webserver projects: drops request dependency on service layer functions
#7228
Conversation
webserver projects: drops request dependency on service layer functions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7228 +/- ##
==========================================
- Coverage 87.02% 83.54% -3.49%
==========================================
Files 1664 646 -1018
Lines 64666 31205 -33461
Branches 1096 168 -928
==========================================
- Hits 56278 26069 -30209
+ Misses 8075 5078 -2997
+ Partials 313 58 -255
Continue to review full report in Codecov by Sentry.
|
e8452cb to
3b70a42
Compare
services/web/server/src/simcore_service_webserver/projects/_crud_api_read.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_crud_api_read.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good! thanks
services/web/server/src/simcore_service_webserver/projects/_crud_handlers.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! At some point, can you please explain to me how the permalink works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|



What do these changes do?
To streamline the review process for upcoming PRs, this update includes refactoring within the
webserver'sprojectsdomain. Key details:requestdependency from_crud_api_readfunctions_crud_api_readfunction previously mixed service layer logic with REST utilities. Since the service layer should not depend onrequest, all dependencies onweb.Requesthave been removed. Instead, a utility function now handles these dependencies within the REST controller.projects_permalink_serviceprojects.apithat reduces coupling with other submodulesruff.lint.argsin.vscode/settings.jsonRelated issue/s
How to test
Dev-ops
None