Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Feb 14, 2025

What do these changes do?

  • since many people are editing files in storage, there is a need to reduce conflicts
  • This PR brings in some light refactoring, e.g. moving local fixtures/helpers to pytest-simcore package
  • adds fastapi-pagination to the requirements

--> no change in functionality. just moving around files

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:storage issue related to storage service t:maintenance Some planned maintenance work labels Feb 14, 2025
@sanderegg sanderegg added this to the Singularity milestone Feb 14, 2025
@sanderegg sanderegg self-assigned this Feb 14, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner February 14, 2025 17:26
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (be9f062) to head (fa1fd7a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7233      +/-   ##
==========================================
+ Coverage   86.99%   87.02%   +0.03%     
==========================================
  Files        1667     1660       -7     
  Lines       64721    64531     -190     
  Branches     1096     1096              
==========================================
- Hits        56302    56158     -144     
+ Misses       8106     8060      -46     
  Partials      313      313              
Flag Coverage Δ
integrationtests 65.25% <ø> (-3.17%) ⬇️
unittests 86.02% <ø> (+0.03%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.53% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.28% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.15% <ø> (ø)
pkg_settings_library 90.61% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.56% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.08% <ø> (ø)
storage 86.61% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.75% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9f062...fa1fd7a. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! 👍

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot for the effort!

@sanderegg sanderegg force-pushed the storage/light-refactor branch from 28c17fb to fa1fd7a Compare February 16, 2025 17:26
@sanderegg sanderegg enabled auto-merge (squash) February 16, 2025 17:26
@sonarqubecloud
Copy link

@sanderegg sanderegg merged commit 73eff71 into ITISFoundation:master Feb 16, 2025
94 of 95 checks passed
@sanderegg sanderegg deleted the storage/light-refactor branch February 17, 2025 07:00
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:storage issue related to storage service t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants