Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 20, 2025

What do these changes do?

The RPC interface for the dynamic-sidecar goes into the direction of restorability and migrating the core services to k8s. This allows us to decouple the networking, since the interface will be RabbitMQ.

NOTE: since the REST interface will be deprecated once the old scheduler used by director-v2 is removed, I am rewriting the tests for the RPC interface decoupled form the REST interface, to allow for easier removal of code

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Feb 20, 2025
@GitHK GitHK added the t:maintenance Some planned maintenance work label Feb 20, 2025
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

❌ Patch coverage is 67.52137% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.90%. Comparing base (ed01dce) to head (dcdb645).
⚠️ Report is 645 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7251      +/-   ##
==========================================
- Coverage   87.12%   86.90%   -0.22%     
==========================================
  Files        1690     1525     -165     
  Lines       65579    61691    -3888     
  Branches     1121      891     -230     
==========================================
- Hits        57133    53614    -3519     
+ Misses       8128     7818     -310     
+ Partials      318      259      -59     
Flag Coverage Δ
integrationtests 65.38% <71.79%> (+0.02%) ⬆️
unittests 86.27% <67.52%> (+0.13%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <100.00%> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 93.11% <0.00%> (+20.35%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling 92.08% <ø> (-4.01%) ⬇️
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.27% <ø> (-0.03%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.74% <100.00%> (+<0.01%) ⬆️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.19% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed01dce...dcdb645. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@GitHK
Copy link
Contributor Author

GitHK commented Aug 29, 2025

replaced by #8227

@GitHK GitHK closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant