Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Feb 21, 2025

What do these changes do?

ReDoc

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 21, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:apiserver api-server service label Feb 21, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Singularity milestone Feb 21, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 21, 2025 13:02
@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.87%. Comparing base (b084481) to head (97ddbdd).
Report is 12 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b084481) and HEAD (97ddbdd). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (b084481) HEAD (97ddbdd)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7257       +/-   ##
===========================================
- Coverage   86.97%   69.87%   -17.11%     
===========================================
  Files        1686      731      -955     
  Lines       65340    33778    -31562     
  Branches     1115      168      -947     
===========================================
- Hits        56829    23602    -33227     
- Misses       8193    10118     +1925     
+ Partials      318       58      -260     
Flag Coverage Δ *Carryforward flag
integrationtests 65.55% <ø> (+0.06%) ⬆️ Carriedforward from 2305d68
unittests 90.56% <ø> (+4.28%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.26% <ø> (-7.82%) ⬇️
agent ∅ <ø> (∅)
api_server 90.56% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.56% <ø> (-12.75%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.41% <ø> (-25.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b084481...97ddbdd. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, by pinning i did not mean the version

I meant "freezing" the licensed_resource_data field in the response model which currently is a object in the model, not the version :-)

image

For the version, we even need to be more careful and even double check with @bisgaard-itis since we need to update the client as well

@sonarqubecloud
Copy link

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know when it's ready again

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for next iteration

@matusdrobuliak66
Copy link
Collaborator Author

#7284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:apiserver api-server service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VIP Models: Data Structure

4 participants