-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ pin api server open api specs #7257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ pin api server open api specs #7257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7257 +/- ##
===========================================
- Coverage 86.97% 69.87% -17.11%
===========================================
Files 1686 731 -955
Lines 65340 33778 -31562
Branches 1115 168 -947
===========================================
- Hits 56829 23602 -33227
- Misses 8193 10118 +1925
+ Partials 318 58 -260
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, by pinning i did not mean the version
I meant "freezing" the licensed_resource_data field in the response model which currently is a object in the model, not the version :-)
For the version, we even need to be more careful and even double check with @bisgaard-itis since we need to update the client as well
|
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me know when it's ready again
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for next iteration




What do these changes do?
Related issue/s
How to test
Dev-ops checklist