Skip to content

🎨 [Frontend] Use Number of Seats defined in the Pricing Unit #7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 3, 2025
Merged

🎨 [Frontend] Use Number of Seats defined in the Pricing Unit #7273

merged 17 commits into from
Mar 3, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 25, 2025 •
edited
Loading

What do these changes do?

The number of seats was extracted from the name of the pricing unit, too bad.

After this PR, the num_of_seats is actually moved to it's own field in the extraInfo and now the frontend uses this field. The Pricing unit creation was also updated and now a License classified units can be created.

NumberOfSeats

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Feb 25, 2025
@odeimaiz odeimaiz added this to the The Awakening milestone Feb 25, 2025
@odeimaiz odeimaiz self-assigned this Feb 25, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Use Number of Seats defined in the UnitData 🎨 [Frontend] Use Number of Seats defined in the Pricing Unit Feb 28, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 28, 2025 12:39
matusdrobuliak66
matusdrobuliak66 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@odeimaiz odeimaiz enabled auto-merge (squash) February 28, 2025 12:42
pcrespov
pcrespov approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! :-)

sanderegg
sanderegg reviewed Mar 3, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit e3cbabb into ITISFoundation:master Mar 3, 2025
57 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@odeimaiz @mrnicegyu11
🎨 [Frontend] Use Number of Seats defined in the Pricing Unit (ITISFou…
52fa710 
…ndation#7273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg left review comments

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@mguidon mguidon Awaiting requested review from mguidon

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

5 participants

@odeimaiz @GitHK @pcrespov @sanderegg @matusdrobuliak66