Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Feb 26, 2025

What do these changes do?

This PR brings url encoding (including / characters) for the display_path field in PathMetaData object.

This is needed as project names and node names may contain any kind of characters including / characters.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Feb 26, 2025
@sanderegg sanderegg added this to the The Awakening milestone Feb 26, 2025
@sanderegg sanderegg self-assigned this Feb 26, 2025
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (5c9e45b) to head (820b7d7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7285       +/-   ##
===========================================
+ Coverage   74.72%   88.40%   +13.68%     
===========================================
  Files        1055     1351      +296     
  Lines       45265    55947    +10682     
  Branches      227      481      +254     
===========================================
+ Hits        33823    49461    +15638     
+ Misses      11372     6354     -5018     
- Partials       70      132       +62     
Flag Coverage Δ
integrationtests 65.37% <ø> (-0.02%) ⬇️
unittests 87.28% <100.00%> (-3.59%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.53% <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (+8.15%) ⬆️
agent 96.46% <ø> (ø)
api_server 90.56% <ø> (ø)
autoscaling 96.08% <ø> (∅)
catalog 91.73% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.06% <ø> (ø)
director 76.59% <ø> (-0.10%) ⬇️
director_v2 91.30% <ø> (+12.71%) ⬆️
dynamic_scheduler 97.33% <ø> (∅)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.22% <ø> (ø)
storage 84.31% <100.00%> (∅)
webclient ∅ <ø> (∅)
webserver 85.22% <ø> (+25.87%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9e45b...820b7d7. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci!

@sanderegg sanderegg force-pushed the storage/path-encode-display-path branch from 14e668e to 95eb0d0 Compare February 27, 2025 09:38
@sanderegg sanderegg enabled auto-merge (squash) February 27, 2025 09:46
@sanderegg sanderegg force-pushed the storage/path-encode-display-path branch from 95eb0d0 to 820b7d7 Compare February 27, 2025 10:25
@sanderegg sanderegg disabled auto-merge February 27, 2025 10:25
@sanderegg sanderegg merged commit 0e9c52d into ITISFoundation:master Feb 27, 2025
2 of 4 checks passed
@sanderegg sanderegg deleted the storage/path-encode-display-path branch February 27, 2025 10:25
@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:storage issue related to storage service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants