-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 When a file is now moved to the output_x folder it is now detected
#7301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 When a file is now moved to the output_x folder it is now detected
#7301
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7301 +/- ##
===========================================
- Coverage 85.50% 67.69% -17.81%
===========================================
Files 1690 656 -1034
Lines 65637 31452 -34185
Branches 1121 168 -953
===========================================
- Hits 56125 21293 -34832
- Misses 9192 10101 +909
+ Partials 320 58 -262
Continue to review full report in Codecov by Sentry.
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/outputs/_event_handler.py
Outdated
Show resolved
Hide resolved
|
ITISFoundation#7301) Co-authored-by: Andrei Neagu <[email protected]>



What do these changes do?
When files were created outside the
output_x(port_key) folder and them moved inside it, the no port upload event was generated.The issue is now fixed, some watchdog events contained the port_key in the
dst_pathinstead of thesrc_path.Related issue/s
How to test
Dev-ops checklist