Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 4, 2025

What do these changes do?

When files were created outside the output_x (port_key) folder and them moved inside it, the no port upload event was generated.

The issue is now fixed, some watchdog events contained the port_key in the dst_path instead of the src_path.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Mar 4, 2025
@GitHK GitHK added bug buggy, it does not work as expected a:dynamic-sidecar dynamic-sidecar service labels Mar 4, 2025
@GitHK GitHK added this to the The Awakening milestone Mar 4, 2025
@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (7870cc8) to head (cfedb81).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7870cc8) and HEAD (cfedb81). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (7870cc8) HEAD (cfedb81)
unittests 29 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7301       +/-   ##
===========================================
- Coverage   85.50%   67.69%   -17.81%     
===========================================
  Files        1690      656     -1034     
  Lines       65637    31452    -34185     
  Branches     1121      168      -953     
===========================================
- Hits        56125    21293    -34832     
- Misses       9192    10101      +909     
+ Partials      320       58      -262     
Flag Coverage Δ
integrationtests 65.38% <15.00%> (-0.09%) ⬇️
unittests 89.23% <95.00%> (+4.78%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.51% <ø> (-12.76%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 90.28% <95.00%> (+0.54%) ⬆️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.38% <ø> (-20.43%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7870cc8...cfedb81. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review March 4, 2025 10:44
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@GitHK GitHK enabled auto-merge (squash) March 4, 2025 12:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

@GitHK GitHK merged commit a776cef into ITISFoundation:master Mar 4, 2025
90 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-inputs-not-uploading branch March 4, 2025 13:14
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:dynamic-sidecar dynamic-sidecar service bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

outputs not updated properly when drag-and-dropping files

4 participants