Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Mar 4, 2025

What do these changes do?

  • Fix flaky api keys test in the web server. From local testing this seems to fix the flakiness.
  • Also fix flaky test_patch_project

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Mar 4, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review March 4, 2025 10:58
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) March 4, 2025 11:10
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (3250473) to head (9c89c44).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7304      +/-   ##
==========================================
- Coverage   85.45%   83.81%   -1.64%     
==========================================
  Files        1645      658     -987     
  Lines       63925    31490   -32435     
  Branches     1121      168     -953     
==========================================
- Hits        54624    26394   -28230     
+ Misses       8981     5038    -3943     
+ Partials      320       58     -262     
Flag Coverage Δ
integrationtests 65.38% <ø> (ø)
unittests 86.77% <ø> (+2.41%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.57% <ø> (-12.70%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.46% <ø> (-0.83%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.32% <ø> (+5.44%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3250473...9c89c44. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bisgaard-itis bisgaard-itis requested a review from pcrespov March 5, 2025 14:20
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

@bisgaard-itis bisgaard-itis merged commit d049740 into ITISFoundation:master Mar 5, 2025
91 of 95 checks passed
@bisgaard-itis bisgaard-itis deleted the fix-flaky-api-keys-tests branch March 6, 2025 05:28
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants