Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 5, 2025

What do these changes do?

A user service can always remove read permissions form files, which causes issues when trying to save the data to S3.

The current fix gives back read accesso to the dynamic-sidecar on all the content generated by the user services.

Bonus:

  • disabled typer's pretty exceptions and locals in tracebacks in director-v2 and dynamic-sidecar CLIs they are making it harder to figure out what's wrong.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Mar 5, 2025
@GitHK GitHK added the t:maintenance Some planned maintenance work label Mar 5, 2025
@GitHK GitHK added this to the The Awakening milestone Mar 5, 2025
@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (21f2405) to head (ae40c05).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (21f2405) and HEAD (ae40c05). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (21f2405) HEAD (ae40c05)
unittests 30 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7307       +/-   ##
===========================================
- Coverage   87.33%   70.51%   -16.82%     
===========================================
  Files        1692      658     -1034     
  Lines       65760    31502    -34258     
  Branches     1121      168      -953     
===========================================
- Hits        57431    22214    -35217     
- Misses       8009     9230     +1221     
+ Partials      320       58      -262     
Flag Coverage Δ
integrationtests 65.38% <47.05%> (+0.01%) ⬆️
unittests 86.01% <70.58%> (-0.47%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.30% <100.00%> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 90.07% <68.75%> (-0.21%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.37% <ø> (-26.43%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21f2405...ae40c05. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK marked this pull request as ready for review March 6, 2025 10:04
@GitHK GitHK requested review from pcrespov and sanderegg as code owners March 6, 2025 10:04
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what means self_container?

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Left some suggestions and questions.

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2025

@GitHK GitHK merged commit f7ce90e into ITISFoundation:master Mar 7, 2025
90 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-user-service-permissions-override branch March 7, 2025 04:12
matusdrobuliak66 pushed a commit to matusdrobuliak66/osparc-simcore that referenced this pull request Mar 7, 2025
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidecar should be able to access files without permission

4 participants