-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 sidecar no longer fails when saving data with missing permissions #7307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 sidecar no longer fails when saving data with missing permissions #7307
Conversation
…rvice-permissions-override
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7307 +/- ##
===========================================
- Coverage 87.33% 70.51% -16.82%
===========================================
Files 1692 658 -1034
Lines 65760 31502 -34258
Branches 1121 168 -953
===========================================
- Hits 57431 22214 -35217
- Misses 8009 9230 +1221
+ Partials 320 58 -262
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…rvice-permissions-override
…rvice-permissions-override
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what means self_container?
...ices/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks_utils.py
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/prometheus_metrics.py
Outdated
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. Left some suggestions and questions.
...ices/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks_utils.py
Outdated
Show resolved
Hide resolved
...ices/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks_utils.py
Show resolved
Hide resolved
…rvice-permissions-override
|
…TISFoundation#7307) Co-authored-by: Andrei Neagu <[email protected]>
…7307) Co-authored-by: Andrei Neagu <[email protected]>
…TISFoundation#7307) Co-authored-by: Andrei Neagu <[email protected]>



What do these changes do?
A user service can always remove read permissions form files, which causes issues when trying to save the data to S3.
The current fix gives back read accesso to the
dynamic-sidecaron all the content generated by the user services.Bonus:
director-v2anddynamic-sidecarCLIs they are making it harder to figure out what's wrong.Related issue/s
How to test
Dev-ops checklist