-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fixes contract limit parameter
#7309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes contract limit parameter
#7309
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7309 +/- ##
===========================================
- Coverage 85.69% 69.69% -16.01%
===========================================
Files 1692 744 -948
Lines 65759 34523 -31236
Branches 1121 168 -953
===========================================
- Hits 56355 24061 -32294
- Misses 9084 10404 +1320
+ Partials 320 58 -262
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you generate these contracts? are there calls to be done?
could that be setup via make openapi-specs ?
And for the record, that limit was wrongly setup before my PR, e.g. the OpenAPI was advertising the wrong numbers.
@sanderegg This is still a work in progress, but these contracts are generated by code on the consumer side (in this case, Sim4Life). Their purpose is to remain unchanged. Of course, in this special situation, you need to talk to the specific consumer, which in this case is Sim4Life. Meanwhile, I also store them as a reference in our codebase. The publishing process is explained in the README file. A special tool called |
bisgaard-itis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
b1df292
into
ITISFoundation:master



What do these changes do?
limitparameter after 🎨Storage: Increased maximum number of returned paths to 1000 #7305Related issue/s
How to test
Dev-ops checklist