Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review March 6, 2025 12:37
@matusdrobuliak66 matusdrobuliak66 self-assigned this Mar 6, 2025
@matusdrobuliak66 matusdrobuliak66 added 🤖-automerge marks PR as ready to be merged for Mergify a:apiserver api-server service labels Mar 6, 2025
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (9f5b9a1) to head (52e9b3e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9f5b9a1) and HEAD (52e9b3e). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (9f5b9a1) HEAD (52e9b3e)
unittests 29 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7309       +/-   ##
===========================================
- Coverage   85.69%   69.69%   -16.01%     
===========================================
  Files        1692      744      -948     
  Lines       65759    34523    -31236     
  Branches     1121      168      -953     
===========================================
- Hits        56355    24061    -32294     
- Misses       9084    10404     +1320     
+ Partials      320       58      -262     
Flag Coverage Δ *Carryforward flag
integrationtests 65.42% <ø> (+0.02%) ⬆️ Carriedforward from a4a3bc3
unittests 90.68% <ø> (+6.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server 90.68% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.60% <ø> (-12.70%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.43% <ø> (-0.86%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.41% <ø> (-20.91%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5b9a1...52e9b3e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you generate these contracts? are there calls to be done?
could that be setup via make openapi-specs ?

And for the record, that limit was wrongly setup before my PR, e.g. the OpenAPI was advertising the wrong numbers.

@matusdrobuliak66
Copy link
Collaborator Author

how do you generate these contracts? are there calls to be done? could that be setup via make openapi-specs ?

And for the record, that limit was wrongly setup before my PR, e.g. the OpenAPI was advertising the wrong numbers.

@sanderegg This is still a work in progress, but these contracts are generated by code on the consumer side (in this case, Sim4Life). Their purpose is to remain unchanged. Of course, in this special situation, you need to talk to the specific consumer, which in this case is Sim4Life.

Meanwhile, I also store them as a reference in our codebase. The publishing process is explained in the README file. A special tool called pact-broker is used for that.

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) March 6, 2025 14:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

@matusdrobuliak66 matusdrobuliak66 merged commit b1df292 into ITISFoundation:master Mar 6, 2025
90 of 94 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:apiserver api-server service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants