Introduce links for async jobs actions (hateos style) in webserver #7320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisgaard-itis
added
the
a:webserver
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7320 +/- ##
==========================================
- Coverage 87.30% 87.15% -0.16%
==========================================
Files 1709 1546 -163
Lines 66361 62651 -3710
Branches 1125 891 -234
==========================================
- Hits 57938 54601 -3337
+ Misses 8103 7791 -312
+ Partials 320 259 -61
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
bisgaard-itis
requested review from
GitHK,
giancarloromeo,
pcrespov and
sanderegg
GitHK
approved these changes
Mar 19, 2025
Contributor
GitHK
left a comment
GitHK
left a comment
There was a problem hiding this comment.
looks ok with me, some minor things
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/storage/data_export.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/tasks/plugin.py
Outdated
Show resolved
Hide resolved
sanderegg
approved these changes
Mar 20, 2025
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
that is very nice thanks! I added a few comments. we can discuss if needed.
packages/models-library/src/models_library/api_schemas_long_running_tasks/tasks.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/01/storage/test_storage_rpc.py
Outdated
Show resolved
Hide resolved
|
bisgaard-itis
merged commit b5230f1
into
ITISFoundation:master
141 of 144 checks passed
1 task
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
…TISFoundation#7320) Co-authored-by: Giancarlo Romeo <[email protected]> Co-authored-by: Sylvain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR redesigns both the webservers api for the async jobs (currently: computing the size of a path and zipping). It also improves on the design of the rpc interface (currently in
storage, but to be moved toservicelibin the future).Webserver task api
/v0/tasks-legacywhich is not included in the openapi specs. The new interface does not break backwards compatibility. The newGET /v0/tasksendpoint retrives both the legacy long running tasks as well as the new async jobs. The HATEOS links will point to the right endpoints for getting the status/results or abort endpoints.Storage async jobs rpc interface
Raise exceptions in
get_resultmethod (for the async jobs in the storage worker) when an error occurred while running the job, it was aborted or is not yet done.Raise exceptions if status/result/abort is requested but the job doesn't exist.
Improve unit testing both in webserver and storage related to async jobs.
Related issue/s
How to test
Dev-ops checklist