-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fix minor director-v0 typing bug #7323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7323 +/- ##
===========================================
- Coverage 87.22% 67.92% -19.31%
===========================================
Files 1705 675 -1030
Lines 66246 32668 -33578
Branches 1124 168 -956
===========================================
- Hits 57784 22189 -35595
- Misses 8142 10421 +2279
+ Partials 320 58 -262
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Co-authored-by: Dustin Kaiser <[email protected]>



What do these changes do?
Casts yarl.URL explicitly to string so that httpx can ingest it.
This fixes the following issue one hits when providing wrong registry credentials to director-v0:
Related issue/s
How to test
Dev-ops checklist