Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Mar 7, 2025

What do these changes do?

Fix Pydantic UserWarnings caused by use of model_copy, that doesn't validate the models.
All the warnings that flooded tests execution in WebServer will disappear as well.

Related issue/s

How to test

pytest -vv -W error::UserWarning --pdb tests/unit/with_dbs/02/test_projects*

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Mar 7, 2025
@giancarloromeo giancarloromeo added this to the The Awakening milestone Mar 7, 2025
@giancarloromeo giancarloromeo changed the title 🐛 Fix Pydantic User Warnings 🐛 Fix Pydantic's UserWarnings Mar 7, 2025
@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.41%. Comparing base (9c10bb2) to head (4a9feac).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7324      +/-   ##
==========================================
+ Coverage   87.39%   87.41%   +0.02%     
==========================================
  Files        1694     1687       -7     
  Lines       65922    65732     -190     
  Branches     1124     1124              
==========================================
- Hits        57611    57462     -149     
+ Misses       7991     7950      -41     
  Partials      320      320              
Flag Coverage Δ
integrationtests 65.34% <ø> (-0.03%) ⬇️
unittests 86.58% <ø> (+0.02%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.24% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.63% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.21% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.48% <ø> (ø)
pkg_settings_library 90.61% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.10% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.27% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.07% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.00% <ø> (-0.11%) ⬇️
storage 86.90% <ø> (+0.04%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.79% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c10bb2...4a9feac. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo changed the title 🐛 Fix Pydantic's UserWarnings 🐛 Clean Pydantic's UserWarnings Mar 7, 2025
@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Mar 7, 2025
@giancarloromeo giancarloromeo marked this pull request as ready for review March 10, 2025 08:17
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@giancarloromeo giancarloromeo enabled auto-merge (squash) March 10, 2025 09:37
@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo merged commit de85c4d into ITISFoundation:master Mar 10, 2025
93 of 95 checks passed
@giancarloromeo giancarloromeo deleted the is6936/fix-user-warnings branch March 10, 2025 12:52
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UserWarning: Pydantic serializer warnings in tests/unit/with_dbs/02/test_projects*

4 participants