-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ webserver: catalog & api_keys renaming of modules #7334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ webserver: catalog & api_keys renaming of modules #7334
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7334 +/- ##
==========================================
+ Coverage 87.35% 88.64% +1.29%
==========================================
Files 1704 1370 -334
Lines 66217 56744 -9473
Branches 1123 481 -642
==========================================
- Hits 57844 50303 -7541
+ Misses 8053 6309 -1744
+ Partials 320 132 -188
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
a14e840 to
c4e29ee
Compare
9e8557e to
96144b5
Compare
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how people managed to use controller to describe the API entrypoints when there was a well known pattern where the controller is the logics part. anyway. just names but still very bad choosing.
bisgaard-itis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Pedro 🤙
I will follow up with the changes we discussed.
services/web/server/src/simcore_service_webserver/catalog/_controller_rest.py
Show resolved
Hide resolved
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
giancarloromeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Only one thing: module names are getting longer and longer (like German words). What about using packages (e.g. controllers/rest instead of controller_rest)?
noted. |
|



What do these changes do?
This PR is part of the ongoing refactoring effort within the
webserver.Following discussions with @bisgaard-itis, it aligns certain conventions in
catalogandapi_keysto be consistent with the patterns established in the refactored domains.This PR refactors and renames various files and imports within the
simcore_service_webserver.catalogandsimcore_service_webserver.api_keysmodules. Specific changes include renaming_exceptions_handlersto_controller_rest_exceptions, consolidating schemas into_controller_rest_schemas, and updating pagination parameters. Additionally, new routes were added for managing service tags.Related issue/s
productdomain #7294How to test
Dev-ops
None