-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Avoid GC form detecting services as orphans when they are not #7354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Avoid GC form detecting services as orphans when they are not #7354
Conversation
…-stop-flaky-gc-detections
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7354 +/- ##
==========================================
- Coverage 85.58% 84.10% -1.48%
==========================================
Files 1705 659 -1046
Lines 66228 31570 -34658
Branches 1124 168 -956
==========================================
- Hits 56682 26553 -30129
+ Misses 9226 4959 -4267
+ Partials 320 58 -262
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
services/web/server/src/simcore_service_webserver/garbage_collector/_core_orphans.py
Outdated
Show resolved
Hide resolved
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. Left some suggestions
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
services/web/server/src/simcore_service_webserver/garbage_collector/_core_orphans.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/garbage_collector/_core_orphans.py
Outdated
Show resolved
Hide resolved
…-stop-flaky-gc-detections
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at aabffe1 |
|
…Foundation#7354) Co-authored-by: Andrei Neagu <[email protected]>



What do these changes do?
Yesterday, during a debug session with a user. The service got shut down. Users sees the spinner with the
stopping SERVICE...message.After a lot of investigating the cause was narrowed down the issue addressed by this PR. The nodes form the user's opened project were not included in the list. I was looking at Redis while this was happening and they project_uuid key was there. So there was no reason for the shutdown to occur.
Related issue/s
How to test
Dev-ops checklist