Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 13, 2025

What do these changes do?

Yesterday, during a debug session with a user. The service got shut down. Users sees the spinner with the stopping SERVICE... message.

After a lot of investigating the cause was narrowed down the issue addressed by this PR. The nodes form the user's opened project were not included in the list. I was looking at Redis while this was happening and they project_uuid key was there. So there was no reason for the shutdown to occur.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Mar 13, 2025
@GitHK GitHK added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work labels Mar 13, 2025
@GitHK GitHK added this to the The Awakening milestone Mar 13, 2025
@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.10%. Comparing base (3519b90) to head (f58977d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7354      +/-   ##
==========================================
- Coverage   85.58%   84.10%   -1.48%     
==========================================
  Files        1705      659    -1046     
  Lines       66228    31570   -34658     
  Branches     1124      168     -956     
==========================================
- Hits        56682    26553   -30129     
+ Misses       9226     4959    -4267     
+ Partials      320       58     -262     
Flag Coverage Δ
integrationtests 65.33% <27.27%> (-0.02%) ⬇️
unittests 87.25% <72.72%> (+2.71%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.69% <ø> (-12.62%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.10% <ø> (-0.98%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.79% <72.72%> (+5.49%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3519b90...f58977d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK marked this pull request as ready for review March 13, 2025 12:08
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Left some suggestions

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Andrei Neagu added 2 commits March 14, 2025 09:06
@GitHK
Copy link
Contributor Author

GitHK commented Mar 14, 2025

@Mergifyio queue

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 14, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at aabffe1

@sonarqubecloud
Copy link

@mergify mergify bot merged commit aabffe1 into ITISFoundation:master Mar 14, 2025
91 of 96 checks passed
@GitHK GitHK deleted the pr-osparc-attempt-stop-flaky-gc-detections branch March 14, 2025 09:10
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants