🎨 Changed confusing wording #7365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 14, 2025 09:15
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7365 +/- ##
==========================================
+ Coverage 86.68% 87.05% +0.37%
==========================================
Files 1711 1340 -371
Lines 66347 55909 -10438
Branches 1124 578 -546
==========================================
- Hits 57511 48673 -8838
+ Misses 8516 7051 -1465
+ Partials 320 185 -135
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
GitHK
requested review from
bisgaard-itis,
eofli,
giancarloromeo and
matusdrobuliak66
odeimaiz
reviewed
Mar 14, 2025
packages/service-library/src/servicelib/aiohttp/rest_middlewares.py
Outdated
Show resolved
Hide resolved
odeimaiz
reviewed
Mar 14, 2025
...ctor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_observer.py
Outdated
Show resolved
Hide resolved
odeimaiz
approved these changes
Mar 14, 2025
sanderegg
approved these changes
Mar 14, 2025
Contributor
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at dcef4b4 |
pcrespov
approved these changes
Mar 14, 2025
|
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
Co-authored-by: Andrei Neagu <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Previously the user would see something like this
We recently had a user reporting an issue and form his message he was getting the feeling that we were already tackling the issue.
I have reworded the error displayed from the backend. I think this version is accurate and gives proper indication on what action the user should take.
Related issue/s
How to test
Dev-ops checklist