Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 18, 2025

What do these changes do?

  • solves moto upgrade is breaking tests in an unfixable way #7086
  • unlock moto library (g3 machine types were removed)
  • added 2 flaky tests
  • added disk-usage monitoring on storage as it seems to be on the limit of github runners
  • upgraded CI runners to run on ubuntu-24.04 which seems to have maybe 10Gb more disk space

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added t:maintenance Some planned maintenance work dependencies labels Mar 18, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 18, 2025
@sanderegg sanderegg self-assigned this Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (0b0e98d) to head (0254f18).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7378      +/-   ##
==========================================
+ Coverage   85.67%   87.34%   +1.66%     
==========================================
  Files        1709     1702       -7     
  Lines       66361    66171     -190     
  Branches     1125     1125              
==========================================
+ Hits        56856    57794     +938     
+ Misses       9185     8057    -1128     
  Partials      320      320              
Flag Coverage Δ
integrationtests 65.27% <ø> (+<0.01%) ⬆️
unittests 86.50% <ø> (+1.87%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.24% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.01% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.11% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.32% <ø> (-0.02%) ⬇️
pkg_settings_library 90.78% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.59% <ø> (-0.10%) ⬇️
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (+0.05%) ⬆️
storage 84.30% <ø> (+0.11%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.80% <ø> (+5.47%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0e98d...0254f18. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the dependencies/release-moto branch from 9b9468d to 65e4e9e Compare March 18, 2025 15:16
@sanderegg sanderegg marked this pull request as ready for review March 18, 2025 16:00
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛵 Thx!

@sanderegg sanderegg force-pushed the dependencies/release-moto branch from ddbb0bc to 39ee5d3 Compare March 18, 2025 17:22
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this

@sanderegg sanderegg force-pushed the dependencies/release-moto branch from 16da1d9 to 0254f18 Compare March 19, 2025 19:17
@sonarqubecloud
Copy link

@sanderegg sanderegg merged commit 755f190 into ITISFoundation:master Mar 19, 2025
192 of 198 checks passed
@sanderegg sanderegg deleted the dependencies/release-moto branch March 19, 2025 20:25
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants