Skip to content

✅ Fixes flaky test: create_troubleshotting_log_message #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025
Merged

✅ Fixes flaky test: create_troubleshotting_log_message #7400

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12d8cbc
compares oecs
pcrespov Mar 20, 2025
0e1eee6
minor
pcrespov Mar 20, 2025
5b3546e
names
pcrespov Mar 20, 2025
1fdaa3d
Merge branch 'master' into fix/flaky-test_create_troubleshotting_log_…
pcrespov Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/service-library/tests/test_logging_errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
import logging

import pytest

from common_library.error_codes import create_error_code
from common_library.error_codes import create_error_code, parse_error_code_parts
from common_library.errors_classes import OsparcErrorMixin
from servicelib.logging_errors import (
create_troubleshotting_log_kwargs,
Expand All @@ -22,7 +21,11 @@ class MyError(OsparcErrorMixin, RuntimeError):
exc = exc_info.value
error_code = create_error_code(exc)

assert exc.error_code() == error_code
eoc1_fingerprint, eoc1_snapshot = parse_error_code_parts(error_code)
eoc2_fingerprint, eoc2_snapshot = parse_error_code_parts(exc.error_code())

assert eoc1_fingerprint == eoc2_fingerprint
assert eoc1_snapshot <= eoc2_snapshot

msg = f"Nice message to user [{error_code}]"

Expand All @@ -45,7 +48,7 @@ class MyError(OsparcErrorMixin, RuntimeError):
assert log_kwargs["extra"] is not None
assert (
# pylint: disable=unsubscriptable-object
log_kwargs["extra"]["log_uid"]
log_kwargs["extra"].get("log_uid")
== "123"
), "user_id is injected as extra from context"

Expand Down
Loading