Skip to content

✨ web-api: User privacy policy extended to username 🗃️ #7402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 21, 2025
Merged

✨ web-api: User privacy policy extended to username 🗃️ #7402

merged 13 commits into from
Mar 21, 2025
+289 −133

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 20, 2025 •
edited
Loading

What do these changes do?

ReDoc

Users can now choose to hide their username from other user's search. By default, username remains discoverable via full or partial matches. With this update, users can opt out, making their profile fully private.

Changes:

  • ✨ Web-api (0.61.2 → 0.61.3)

    • userName is now nullable (set to None when hidden)
    • Hidden username is excluded from search results

  • 🗃️ Database

    • Added privacy_hide_username column (default: False)

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_*user*.py

Dev-ops

None

@pcrespov pcrespov changed the title ✨ Is38/username privacy ✨ web: User privacy policy extended to username Mar 20, 2025
@pcrespov pcrespov changed the title ✨ web: User privacy policy extended to username ✨ web: User privacy policy extended to username 🗃️ Mar 20, 2025
@codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (8944b1f) to head (ae47f89).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7402      +/-   ##
==========================================
+ Coverage   87.30%   87.33%   +0.03%     
==========================================
  Files        1712     1705       -7     
  Lines       66430    66240     -190     
  Branches     1125     1125              
==========================================
- Hits        57998    57854     -144     
+ Misses       8112     8066      -46     
  Partials      320      320
Flag Coverage Δ
integrationtests 65.29% <66.66%> (+<0.01%) ⬆️
unittests 86.51% <91.66%> (+0.03%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.24% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.04% <100.00%> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.11% <100.00%> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.24% <ø> (ø)
pkg_settings_library 90.78% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.61% <ø> (ø)
director_v2 91.27% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.96% <ø> (-0.17%) ⬇️
storage 84.48% <ø> (+0.23%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.83% <66.66%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8944b1f...ae47f89. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov self-assigned this Mar 20, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Mar 20, 2025
@pcrespov pcrespov added this to the The Awakening milestone Mar 20, 2025
@pcrespov pcrespov marked this pull request as ready for review March 20, 2025 15:07
@pcrespov pcrespov requested a review from odeimaiz March 20, 2025 15:07
@pcrespov pcrespov enabled auto-merge (squash) March 20, 2025 15:07
odeimaiz
odeimaiz approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very nice, thanks

@pcrespov pcrespov changed the title ✨ web: User privacy policy extended to username 🗃️ ✨ web-api: User privacy policy extended to username 🗃️ Mar 20, 2025
GitHK
GitHK approved these changes Mar 21, 2025
View reviewed changes
@pcrespov pcrespov force-pushed the is38/username-privacy branch from e3f2ec1 to 8eb1612 Compare March 21, 2025 07:03
@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 21, 2025
@pcrespov
Copy link
Member Author

pcrespov commented Mar 21, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

sanderegg
sanderegg approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov pcrespov disabled auto-merge March 21, 2025 12:14
@pcrespov pcrespov merged commit 9810d3f into ITISFoundation:master Mar 21, 2025
93 of 94 checks passed
@pcrespov pcrespov deleted the is38/username-privacy branch March 21, 2025 12:14
@odeimaiz odeimaiz mentioned this pull request Mar 21, 2025
Merged
1 task
@pcrespov pcrespov mentioned this pull request Mar 21, 2025
Merged
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@pcrespov @mrnicegyu11
✨ web-api: User privacy policy extended to username 🗃️ (ITISFoundat…
706b034 
…ion#7402)
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo giancarloromeo is a code owner

Assignees

@pcrespov pcrespov

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

4 participants

@pcrespov @GitHK @odeimaiz @sanderegg