🎨 [Frontend] Feature: Hide username #7406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
giancarloromeo
approved these changes
Mar 21, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7406 +/- ##
==========================================
+ Coverage 87.31% 88.36% +1.05%
==========================================
Files 1712 1381 -331
Lines 66430 53976 -12454
Branches 1125 615 -510
==========================================
- Hits 58004 47697 -10307
+ Misses 8106 6108 -1998
+ Partials 320 171 -149
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…sparc-simcore into feature/hide-username
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 81c58df |
|
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
Co-authored-by: Pedro Crespo-Valero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Following #7402 and #7408, this PR exposes the
hideUsernameprivacy setting.When all three searchable fields are hidden, a warning message is shown explaining that "If all searchable fields are hidden, you will not be findable." Also, next to the user data fields a small eye icon is shown representing which fields are visible, for now I prefer not to have these icons interactive.
Related issue/s
How to test
Dev-ops checklist