Skip to content

🎨Maintenance: make devel mode faster to boot + log fixes + webserver DB disable write to disk #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 21, 2025
Merged

🎨Maintenance: make devel mode faster to boot + log fixes + webserver DB disable write to disk #7403

merged 5 commits into from
Mar 21, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 20, 2025 •
edited
Loading

What do these changes do?

  • make booting in devel mode faster by mounting the host UV cache in the containers
  • do not log a cancellation of the client when a handler completed (fastapi cancellation middleware)
  • disable DB writing to disk as this is not necessary during test (initial test with the webserver) - not sure it changes much

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Mar 20, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 20, 2025
@sanderegg sanderegg self-assigned this Mar 20, 2025
@codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.34%. Comparing base (728db70) to head (14b9e1d).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7403      +/-   ##
==========================================
- Coverage   87.34%   87.34%   -0.01%     
==========================================
  Files        1712     1705       -7     
  Lines       66428    66239     -189     
  Branches     1125     1125              
==========================================
- Hits        58020    57854     -166     
+ Misses       8088     8065      -23     
  Partials      320      320
Flag Coverage Δ
integrationtests 65.28% <ø> (-0.03%) ⬇️
unittests 86.51% <66.66%> (+<0.01%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.24% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.04% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.11% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.26% <66.66%> (+<0.01%) ⬆️
pkg_settings_library 90.78% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.68% <ø> (+0.09%) ⬆️
director_v2 91.30% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.15% <ø> (-0.98%) ⬇️
storage 84.40% <ø> (-0.28%) ⬇️
webclient ∅ <ø> (∅)
webserver 85.90% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728db70...14b9e1d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 20, 2025
@sanderegg
Copy link
Member Author

sanderegg commented Mar 20, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = unit-tests
        • check-skipped = unit-tests
        • check-success = unit-tests
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

pcrespov
pcrespov approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice enhancements! thx!

mrnicegyu11
mrnicegyu11 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sanderegg
Copy link
Member Author

sanderegg commented Mar 21, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = unit-tests
        • check-skipped = unit-tests
        • check-success = unit-tests
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bisgaard-itis
bisgaard-itis approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thanks for the effort.

@sanderegg sanderegg merged commit 85e24e8 into ITISFoundation:master Mar 21, 2025
91 of 94 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@sanderegg @mrnicegyu11
🎨Maintenance: make devel mode faster to boot + log fixes + webserver …
164e341 
…DB disable write to disk (ITISFoundation#7403)
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

Assignees

@sanderegg sanderegg

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

5 participants

@sanderegg @GitHK @mrnicegyu11 @pcrespov @bisgaard-itis