Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 26, 2025

What do these changes do?

The new prettified emails:

  • header: product logo in it
  • body: links replaced with buttons with product's strong color as background color
  • footer: link to the product homepage, emailto:support and link to simcore github

Sim4Life
osparc
tip

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Mar 26, 2025
@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (f2a3fd7) to head (47087d5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7432      +/-   ##
==========================================
+ Coverage   85.78%   87.44%   +1.65%     
==========================================
  Files        1728     1721       -7     
  Lines       66802    66622     -180     
  Branches     1133     1133              
==========================================
+ Hits        57304    58255     +951     
+ Misses       9177     8046    -1131     
  Partials      321      321              
Flag Coverage Δ
integrationtests 65.18% <50.00%> (+0.03%) ⬆️
unittests 86.61% <100.00%> (+1.86%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.90% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.05% <ø> (ø)
pkg_notifications_library 85.00% <100.00%> (+0.42%) ⬆️
pkg_postgres_database 88.14% <100.00%> (+0.02%) ⬆️
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.49% <ø> (ø)
pkg_settings_library 90.78% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.73% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.82% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.61% <ø> (-0.10%) ⬇️
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage 86.87% <ø> (+0.18%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.86% <100.00%> (+5.44%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a3fd7...47087d5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz odeimaiz changed the title 🎨 [Frontend] Prettify emails 🎨 Prettify emails Mar 26, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:notifications-library labels Mar 26, 2025
@odeimaiz odeimaiz added this to the The Awakening milestone Mar 26, 2025
@odeimaiz odeimaiz marked this pull request as ready for review March 28, 2025 15:25
@odeimaiz odeimaiz requested a review from giancarloromeo March 28, 2025 15:26
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Left some suggertsions

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty!

@sonarqubecloud
Copy link

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 31, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 3a4bf81

@mergify mergify bot merged commit 3a4bf81 into ITISFoundation:master Mar 31, 2025
94 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants