-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Prettify emails #7432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Prettify emails #7432
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7432 +/- ##
==========================================
+ Coverage 85.78% 87.44% +1.65%
==========================================
Files 1728 1721 -7
Lines 66802 66622 -180
Branches 1133 1133
==========================================
+ Hits 57304 58255 +951
+ Misses 9177 8046 -1131
Partials 321 321
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…simcore into enh/prettify-base-email
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. Left some suggertsions
packages/notifications-library/src/notifications_library/_models.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/products/_models.py
Outdated
Show resolved
Hide resolved
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
H
packages/notifications-library/src/notifications_library/templates/base.html
Outdated
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty!
|
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3a4bf81 |



What do these changes do?
The new prettified emails:
Related issue/s
How to test
Dev-ops