Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 26, 2025

What do these changes do?

this PR sets up the base framework for testing storage with a storage celery worker (fixture with_storage_celery_worker)

  • test/modules/celery --> gone
  • test_modules_celery.py now there with example on how to use it

@giancarloromeo now needs to use the redis/rabbitmq instead of cache:memory I guess.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Mar 26, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 26, 2025
@sanderegg sanderegg self-assigned this Mar 26, 2025
@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.44%. Comparing base (d0d22ce) to head (43dc3b8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7438      +/-   ##
==========================================
+ Coverage   87.32%   87.44%   +0.11%     
==========================================
  Files        1714     1708       -6     
  Lines       66602    66423     -179     
  Branches     1131     1132       +1     
==========================================
- Hits        58159    58082      -77     
+ Misses       8121     8020     -101     
+ Partials      322      321       -1     
Flag Coverage Δ
integrationtests 65.14% <ø> (-0.05%) ⬇️
unittests 86.61% <67.74%> (+0.11%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.24% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.05% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.11% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.97% <86.66%> (-0.06%) ⬇️
pkg_settings_library 90.78% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.61% <ø> (ø)
director_v2 91.30% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage 86.29% <50.00%> (+1.72%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.76% <ø> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d22ce...43dc3b8. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks a lot!

@sonarqubecloud
Copy link

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go go go

@sanderegg sanderegg merged commit d8b3828 into ITISFoundation:master Mar 26, 2025
91 of 92 checks passed
@sanderegg sanderegg deleted the celery/test-worksforme branch March 26, 2025 17:59
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:storage issue related to storage service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants