Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Mar 27, 2025

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis changed the title 🎨 Romeo use async redis client 🎨 Use async redis client Mar 27, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2,3 questions

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (c535784) to head (51bd9f2).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c535784) and HEAD (51bd9f2). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (c535784) HEAD (51bd9f2)
unittests 29 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7443       +/-   ##
===========================================
- Coverage   85.80%   68.81%   -16.99%     
===========================================
  Files        1718      729      -989     
  Lines       66683    34332    -32351     
  Branches     1132      168      -964     
===========================================
- Hits        57217    23627    -33590     
- Misses       9145    10647     +1502     
+ Partials      321       58      -263     
Flag Coverage Δ
integrationtests 65.17% <ø> (+0.01%) ⬆️
unittests 86.20% <94.73%> (+1.43%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.52% <ø> (-12.78%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 86.20% <94.73%> (+0.08%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.13% <ø> (-21.29%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c535784...51bd9f2. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@bisgaard-itis bisgaard-itis requested a review from sanderegg March 27, 2025 14:53
@sanderegg sanderegg merged commit 5bbcc74 into ITISFoundation:master Mar 27, 2025
91 of 94 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants