Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 31, 2025

What do these changes do?

In this PR, the frontend uses the new batch delete endpoint, for deleting one or more files/paths

Bonus

  • Improved the file navigation UX

BatchDelete

Related issue/s

How to test

Dev-ops checklist

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.24%. Comparing base (f09b9c2) to head (b7c211a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7458      +/-   ##
==========================================
- Coverage   87.39%   87.24%   -0.16%     
==========================================
  Files        1728     1562     -166     
  Lines       66821    63062    -3759     
  Branches     1133      899     -234     
==========================================
- Hits        58401    55016    -3385     
+ Misses       8099     7786     -313     
+ Partials      321      260      -61     
Flag Coverage Δ
integrationtests 65.15% <40.00%> (-0.01%) ⬇️
unittests 86.36% <89.74%> (-0.22%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.05% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.42% <0.00%> (-0.06%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.73% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.82% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.18% <ø> (ø)
storage 86.80% <100.00%> (+0.15%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.86% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09b9c2...b7c211a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz odeimaiz changed the title Feature/batch delete files 🎨 [Frontend] Enh: batch delete files Apr 1, 2025
@odeimaiz odeimaiz marked this pull request as ready for review April 1, 2025 15:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

@odeimaiz odeimaiz requested a review from giancarloromeo April 1, 2025 15:13
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

  • What if I select them all and the total exceeds 1000? Should there be some progress indicator for the deletion process?
  • Can you cancel/interrupt deletion in that case?

@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 1, 2025

Cool!

  • What if I select them all and the total exceeds 1000? Should there be some progress indicator for the deletion process?
  • Can you cancel/interrupt deletion in that case?

I'll think about it 👍

@odeimaiz odeimaiz merged commit c1f0a35 into ITISFoundation:master Apr 1, 2025
57 checks passed
@odeimaiz odeimaiz deleted the feature/batch-delete-files branch April 2, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants