Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 1, 2025

What do these changes do?

  • added fail fast conditions when:
    • computational pipeline goes into FAILED,ABORTED state instead of waiting super long
    • dynamic service goes into IDLE, FAILED service state by checking websocket ServiceStatus message
    • 409 is raised when opening a project
  • added missing states when checking for node progress types
  • catch exception in playwright callback (that is very bad as this implies infinite loops)
  • in case of dynamic service failing on start, all the websocket messages are json-formatted and written into websocket.json file in the test-results output for later debugging

Related issue/s

E2E TIP issues

How to test

Dev-ops checklist

@sanderegg sanderegg added t:maintenance Some planned maintenance work e2e Bugs found by or related to the end-2-end testing labels Apr 1, 2025
@sanderegg sanderegg added this to the The Awakening milestone Apr 1, 2025
@sanderegg sanderegg self-assigned this Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (c1f0a35) to head (0c8dc98).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7463      +/-   ##
==========================================
+ Coverage   79.99%   87.43%   +7.44%     
==========================================
  Files        1625     1722      +97     
  Lines       62050    66674    +4624     
  Branches     1133     1133              
==========================================
+ Hits        49634    58299    +8665     
+ Misses      12095     8054    -4041     
  Partials      321      321              
Flag Coverage Δ
integrationtests 65.19% <ø> (+5.19%) ⬆️
unittests 86.59% <ø> (+7.49%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.90% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.05% <ø> (ø)
pkg_notifications_library 85.00% <ø> (ø)
pkg_postgres_database 88.14% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.42% <ø> (ø)
pkg_settings_library 90.78% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.73% <ø> (ø)
autoscaling 96.08% <ø> (∅)
catalog 91.82% <ø> (+0.11%) ⬆️
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.87% <ø> (+0.09%) ⬆️
director_v2 91.28% <ø> (+5.75%) ⬆️
dynamic_scheduler 97.35% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage 86.83% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.87% <ø> (+20.23%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f0a35...0c8dc98. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci 🙏

@sanderegg sanderegg force-pushed the e2e/improve-websocket-handling branch from b0eeda8 to 0c8dc98 Compare April 1, 2025 16:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

@sanderegg sanderegg merged commit 7dd5842 into ITISFoundation:master Apr 1, 2025
41 checks passed
@sanderegg sanderegg deleted the e2e/improve-websocket-handling branch April 1, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants