Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 2, 2025

What do these changes do?

As preparation for share-project-via-email, we want to expose the access rights given to the collaborators when sharing a resource. At the moment, when sharing a Study, collaborators get the defaulted write access rights (these defaults, which depend on the resource type, are hardcoded in the frontend). If that's not the access right the Sharer wants to give, after sharing they would need to go through the list of collaborators and update the permissions.

With this PR, these two operations are handled at the same time, providing a better UX.

Bonus:

  • Refactor Roles related data.

SelectAccessRights

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 2, 2025
@odeimaiz odeimaiz added this to the The Awakening milestone Apr 2, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Apr 2, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Share Study with email 🎨 [Frontend] Enh: Expose access rights when Sharing Study Apr 2, 2025
@odeimaiz odeimaiz marked this pull request as ready for review April 3, 2025 09:57
@odeimaiz odeimaiz requested a review from giancarloromeo April 3, 2025 10:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2025

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 3, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 3, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5b1d439

@mergify mergify bot merged commit 5b1d439 into ITISFoundation:master Apr 3, 2025
58 checks passed
@odeimaiz odeimaiz deleted the feature/share-with-email branch April 3, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants