Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 7, 2025

What do these changes do?

In this PR, when a Study is being shared and the user types an email address, a "Send email" button is shown. If this is clicked, that email will be added to the potential sharees list with a different "check" icon. Also, the sharer can type a message that will be injected in the sharing email.

For now, this feature is enabled in development platforms only.

ShareWithEmail

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 7, 2025
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 7, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Apr 7, 2025
@odeimaiz odeimaiz marked this pull request as ready for review April 7, 2025 13:49
@odeimaiz odeimaiz changed the title ✨ [Frontend] Feature: Share via email ✨ [Frontend] Feature: Share Study via email Apr 7, 2025
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Q: Are you using some backend functionality for sending emails?

@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 7, 2025

👍 Q: Are you using some backend functionality for sending emails?

If that's the case, Mr Asdf might have reported us as spammers 😬

More Backend info here and, eventually, this is the template that will be used.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. Will follow up on this .

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 7, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 7, 2025

@Mergifyio queue

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at bff03eb

@mergify mergify bot merged commit bff03eb into ITISFoundation:master Apr 7, 2025
58 checks passed
@odeimaiz odeimaiz deleted the feature/share-via-email branch April 7, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants