- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
Is7420/permanently delete trashed workspaces #7482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is7420/permanently delete trashed workspaces #7482
Conversation
…y-delete-workspaces
…ncarloromeo/osparc-simcore into is7034/permanently-delete-workspaces
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #7482      +/-   ##
==========================================
- Coverage   87.61%   84.26%   -3.36%     
==========================================
  Files        1747      680    -1067     
  Lines       67648    32088   -35560     
  Branches     1121      170     -951     
==========================================
- Hits        59270    27038   -32232     
+ Misses       8070     4992    -3078     
+ Partials      308       58     -250     
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. please check this cleanup suggestions
        
          
                ...b/server/tests/unit/with_dbs/04/workspaces/test_workspaces__delete_workspace_with_content.py
          
            Show resolved
            Hide resolved
        
              
          
                ...b/server/tests/unit/with_dbs/04/workspaces/test_workspaces__delete_workspace_with_content.py
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
large. seems ok. thanks a lot!
        
          
                services/web/server/src/simcore_service_webserver/folders/_folders_service.py
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/folders/_trash_service.py
          
            Show resolved
            Hide resolved
        
      | 
           @mergify queue  | 
    
          
 🟠 Waiting for conditions to match
  | 
    
| 
           @mergify stop  | 
    
          
 ❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. | 
    
          
 | 
    
44972f0
      into
      
  
    ITISFoundation:master
  
    


What do these changes do?
Related issue/s
How to test
test_trash_rest.pytest_trash_service.pyDev-ops checklist