Skip to content

Is7420/permanently delete trashed workspaces #7482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Apr 22, 2025
Merged

Is7420/permanently delete trashed workspaces #7482

merged 35 commits into from
Apr 22, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Apr 7, 2025 •
edited
Loading

What do these changes do?

  • 🎨 Implement deletion of trashed workspaces

Related issue/s

How to test

  • test_trash_rest.py
  • test_trash_service.py

Dev-ops checklist

giancarloromeo and others added 15 commits March 25, 2025 13:03
@giancarloromeo
initial commit
1205448
@giancarloromeo
add child folders listing
07dba85
@giancarloromeo
add child projects
cb4f9fa
@giancarloromeo
Merge branch 'master' into is7034/permanently-delete-workspaces
b1fd5a8
@giancarloromeo
Merge remote-tracking branch 'upstream/master' into is7034/permanentl…
a0eace1 
…y-delete-workspaces
@giancarloromeo
Merge branch 'master' into is7034/permanently-delete-workspaces
840da08
@giancarloromeo
Merge branch 'is7034/permanently-delete-workspaces' of github.com:gia…
d6fec00 
…ncarloromeo/osparc-simcore into is7034/permanently-delete-workspaces
@matusdrobuliak66
Merge branch 'master' into is7420/permanently-delete-trashed-workspaces
ad02e49
@matusdrobuliak66
update name
517065d
@matusdrobuliak66
Merge branch 'master' into is7420/permanently-delete-trashed-workspaces
77c558a
@matusdrobuliak66
Merge branch 'master' into is7420/permanently-delete-trashed-workspaces
74ee277
@matusdrobuliak66
update
696a19b
@matusdrobuliak66
improve delete workspace
f382a0d
@matusdrobuliak66
Merge branch 'master' into is7420/permanently-delete-trashed-workspaces
ce4c77a
@matusdrobuliak66
improve delete workspace
3df89fc
@matusdrobuliak66 matusdrobuliak66 self-assigned this Apr 7, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Pauwel Kwak milestone Apr 7, 2025
@codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.66667% with 58 lines in your changes missing coverage. Please review.

Project coverage is 84.26%. Comparing base (e36b197) to head (b0f6e7a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7482      +/-   ##
==========================================
- Coverage   87.61%   84.26%   -3.36%     
==========================================
  Files        1747      680    -1067     
  Lines       67648    32088   -35560     
  Branches     1121      170     -951     
==========================================
- Hits        59270    27038   -32232     
+ Misses       8070     4992    -3078     
+ Partials      308       58     -250
Flag Coverage Δ
integrationtests 65.11% <45.00%> (-0.15%) ⬇️
unittests 87.47% <80.66%> (+0.66%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.24% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.54% <ø> (-12.77%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 86.05% <80.66%> (+0.06%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36b197...b0f6e7a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: Is7420/permanently delete trashed workspaces Is7420/permanently delete trashed workspaces Apr 8, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review April 8, 2025 12:42
@matusdrobuliak66 matusdrobuliak66 requested a review from GitHK April 8, 2025 13:39
pcrespov
pcrespov approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. please check this cleanup suggestions

sanderegg
sanderegg approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

large. seems ok. thanks a lot!

@pcrespov pcrespov enabled auto-merge (squash) April 10, 2025 08:20
@pcrespov pcrespov enabled auto-merge (squash) April 10, 2025 11:48
@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 10, 2025
@pcrespov
Copy link
Member

pcrespov commented Apr 10, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)

@matusdrobuliak66
Copy link
Collaborator Author

matusdrobuliak66 commented Apr 10, 2025

@mergify stop

@matusdrobuliak66 matusdrobuliak66 added 🤖-do-not-merge (optional) blocks Mergify from merging the PR and removed 🤖-automerge marks PR as ready to be merged for Mergify labels Apr 10, 2025
@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

stop

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@matusdrobuliak66 matusdrobuliak66 added 🤖-automerge marks PR as ready to be merged for Mergify and removed 🤖-do-not-merge (optional) blocks Mergify from merging the PR labels Apr 16, 2025
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) April 22, 2025 10:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit 44972f0 into ITISFoundation:master Apr 22, 2025
90 of 94 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

Implement deletion of trashed workspaces

5 participants

@matusdrobuliak66 @pcrespov @giancarloromeo @GitHK @sanderegg