Skip to content

🐛 [Frontend] Fixes: delete(d) Workspaces #7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 7, 2025
Merged

🐛 [Frontend] Fixes: delete(d) Workspaces #7484

merged 5 commits into from
Apr 7, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 7, 2025 •
edited
Loading

What do these changes do?

Reported by @matusdrobuliak66

  • Do not add the deleted workspaces to cache
  • Disable drag&drop on Trashed items

DeleteWorkspaces

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 7, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Apr 7, 2025
@odeimaiz odeimaiz modified the milestones: Pauwel Kwak, The Awakening Apr 7, 2025
@odeimaiz odeimaiz marked this pull request as ready for review April 7, 2025 14:45
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 7, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 7, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4a00345

matusdrobuliak66
matusdrobuliak66 approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pcrespov
pcrespov approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mergify mergify bot merged commit 4a00345 into ITISFoundation:master Apr 7, 2025
58 checks passed
@odeimaiz odeimaiz deleted the minors/remove-workspace branch April 8, 2025 07:57
This was referenced Apr 10, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@GitHK GitHK Awaiting requested review from GitHK

@alexpargon alexpargon Awaiting requested review from alexpargon

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

3 participants

@odeimaiz @pcrespov @matusdrobuliak66