🎨 [Frontend] Enh service calls: avoid request deduplication #7487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
requested review from
GitHK,
alexpargon,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 2d2d69e |
matusdrobuliak66
approved these changes
Apr 8, 2025
Collaborator
matusdrobuliak66
left a comment
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Nice! Btw if we would remove the total count from service listing and move to cursor, that would also speed up the listing 👍
Member
Author
I think that the current |
|
GitHK
approved these changes
Apr 8, 2025
This was referenced Apr 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR fixes the classic "duplicate requests flood" problem. It happens a lot when multiple cards in the dashboard fetch the same service's metadata in parallel.
To solve it, a shared fetch cache or request deduplication was implemented.
Before:
After:
Related issue/s
How to test
Dev-ops checklist