Skip to content

🎨 state of webserverDevFeaturesEnabled flag is passed in statics for the front-end #7490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

🎨 state of webserverDevFeaturesEnabled flag is passed in statics for the front-end #7490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14b0a9c
adds devfeatures
pcrespov Apr 8, 2025
dc30e23
Merge branch 'master' into mai/devel-flag
pcrespov Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion services/web/server/src/simcore_service_webserver/application_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,17 +540,18 @@ def to_client_statics(self) -> dict[str, Any]:
"SIMCORE_VCS_RELEASE_TAG": True,
"SIMCORE_VCS_RELEASE_URL": True,
"SWARM_STACK_NAME": True,
"WEBSERVER_DEV_FEATURES_ENABLED": True,
"WEBSERVER_LOGIN": {
"LOGIN_ACCOUNT_DELETION_RETENTION_DAYS",
"LOGIN_2FA_REQUIRED",
},
"WEBSERVER_PROJECTS": {
"PROJECTS_MAX_NUM_RUNNING_DYNAMIC_NODES",
},
"WEBSERVER_SESSION": {"SESSION_COOKIE_MAX_AGE"},
"WEBSERVER_TRASH": {
"TRASH_RETENTION_DAYS",
},
"WEBSERVER_SESSION": {"SESSION_COOKIE_MAX_AGE"},
},
exclude_none=True,
)
Expand Down
1 change: 1 addition & 0 deletions services/web/server/tests/unit/isolated/test_application_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ def test_settings_to_client_statics_plugins(
assert settings.WEBSERVER_LOGIN

assert "webserverLicenses" not in statics
assert "webserverDevFeaturesEnabled" in statics

assert (
statics["webserverLogin"]["LOGIN_ACCOUNT_DELETION_RETENTION_DAYS"]
Expand Down
Loading