-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ lifespans cleanup #7496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ lifespans cleanup #7496
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7496 +/- ##
==========================================
- Coverage 87.45% 87.27% -0.18%
==========================================
Files 1739 1370 -369
Lines 67368 56908 -10460
Branches 1142 594 -548
==========================================
- Hits 58914 49668 -9246
+ Misses 8134 7055 -1079
+ Partials 320 185 -135
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup. thx . Left a few suggestions.
packages/service-library/src/servicelib/fastapi/postgres_lifespan.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/fastapi/prometheus_instrumentation.py
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
packages/service-library/src/servicelib/fastapi/lifespan_utils.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/fastapi/prometheus_instrumentation.py
Show resolved
Hide resolved
…espan-style-for-dynamic-scheduler
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 51d6c06 |
…espan-style-for-dynamic-scheduler
|



What do these changes do?
Align all services using lifespans to the same standard
lifespan_XXXtoXXX_lifespanto align to new standardStateto resolve settings_main_lifespanRelated issue/s
How to test
Dev-ops checklist