Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Apr 9, 2025

What do these changes do?

Align all services using lifespans to the same standard

  • renamed lifespan_XXX to XXX_lifespan to align to new standard
  • remove lifespans build via constructors they all now rely on State to resolve settings
  • never expose internal keys to other modules instead use utility functions for the _main_lifespan

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Apr 9, 2025
@GitHK GitHK added the t:maintenance Some planned maintenance work label Apr 9, 2025
@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 75.49020% with 25 lines in your changes missing coverage. Please review.

Project coverage is 87.27%. Comparing base (ab69603) to head (958fa49).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7496      +/-   ##
==========================================
- Coverage   87.45%   87.27%   -0.18%     
==========================================
  Files        1739     1370     -369     
  Lines       67368    56908   -10460     
  Branches     1142      594     -548     
==========================================
- Hits        58914    49668    -9246     
+ Misses       8134     7055    -1079     
+ Partials      320      185     -135     
Flag Coverage Δ
integrationtests 65.16% <ø> (-0.02%) ⬇️
unittests 86.29% <75.49%> (-0.35%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.66% <10.71%> (-0.16%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.40% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.02% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.52% <100.00%> (-0.02%) ⬇️
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 91.30% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.40% <100.00%> (+0.05%) ⬆️
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.18% <ø> (ø)
storage 87.98% <ø> (+0.29%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.92% <ø> (+0.05%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab69603...958fa49. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK marked this pull request as ready for review April 10, 2025 07:07
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. thx . Left a few suggestions.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@GitHK GitHK added this to the Pauwel Kwak milestone Apr 10, 2025
@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 10, 2025
@GitHK
Copy link
Contributor Author

GitHK commented Apr 10, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 51d6c06

Andrei Neagu added 2 commits April 11, 2025 06:29
@sonarqubecloud
Copy link

@mergify mergify bot merged commit 51d6c06 into ITISFoundation:master Apr 11, 2025
94 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-new-lifespan-style-for-dynamic-scheduler branch April 11, 2025 05:09
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants