Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Apr 9, 2025

What do these changes do?

  • Restrict export data only for a select of files and folders coming from the same folder.
  • No longer include the full path from the bucket root. Only include the path with regard to the user selection. Eg: /some/selection/in/the/bucket/file/ will add only file inside the archive.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Apr 9, 2025
@GitHK GitHK added this to the Pauwel Kwak milestone Apr 9, 2025
@GitHK GitHK added the a:storage issue related to storage service label Apr 9, 2025
@GitHK GitHK changed the title ♻️ allow export data only for user selection coming form the same folder ♻️ export data feature enhancements Apr 9, 2025
@GitHK GitHK marked this pull request as ready for review April 9, 2025 14:28
@GitHK GitHK requested a review from sanderegg as a code owner April 9, 2025 14:28
@GitHK GitHK requested a review from matusdrobuliak66 April 9, 2025 14:30
@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.03%. Comparing base (e838468) to head (d54efc7).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e838468) and HEAD (d54efc7). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (e838468) HEAD (d54efc7)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7498       +/-   ##
===========================================
- Coverage   87.44%   69.03%   -18.41%     
===========================================
  Files        1741      739     -1002     
  Lines       67359    34610    -32749     
  Branches     1142      170      -972     
===========================================
- Hits        58900    23894    -35006     
- Misses       8139    10658     +2519     
+ Partials      320       58      -262     
Flag Coverage Δ
integrationtests 65.20% <ø> (+0.04%) ⬆️
unittests 87.91% <90.00%> (+1.29%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.24% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.88% <ø> (-12.42%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 87.91% <90.00%> (+0.10%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.10% <ø> (-26.78%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e838468...d54efc7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand why the storage service must take care of this restriction. Added a few comments.

@GitHK
Copy link
Contributor Author

GitHK commented Apr 10, 2025

@Mergifyio queue

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 10, 2025
@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b253cb0

Andrei Neagu added 2 commits April 10, 2025 09:17
@sonarqubecloud
Copy link

@mergify mergify bot merged commit b253cb0 into ITISFoundation:master Apr 10, 2025
92 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-filter-export-selection-by-path branch April 10, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:storage issue related to storage service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants