Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 10, 2025

What do these changes do?

This PR fixes a bug that is reproducible if the latest version of a service is deprecated but not a previous one.

More fixes:

  • Share widget (reported by @sanderegg)
  • Unblock cards (studies and templates) that do not use the latest version of a service (reported by @sanderegg)

Scenario:
ServiceSetup

Buggy:
DoNotShowRetired

Fixed:
DoNotShowRetiredFixed

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 10, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Apr 10, 2025
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 10, 2025
@odeimaiz odeimaiz marked this pull request as ready for review April 10, 2025 14:02
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 10, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias!

@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit f35d515 into ITISFoundation:master Apr 11, 2025
57 checks passed
@odeimaiz odeimaiz deleted the fix/do-not-list-deprecated branch April 11, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants