Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Apr 10, 2025

What do these changes do?

When exporting data, project_id is replaced with the project's name while node_id is replaced with the node's label.
Also, special character / is escaped with _.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Apr 10, 2025
@GitHK GitHK added this to the Pauwel Kwak milestone Apr 10, 2025
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (44972f0) to head (3837231).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (44972f0) and HEAD (3837231). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (44972f0) HEAD (3837231)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7508       +/-   ##
===========================================
- Coverage   87.59%   68.93%   -18.67%     
===========================================
  Files        1752      746     -1006     
  Lines       67846    34940    -32906     
  Branches     1121      170      -951     
===========================================
- Hits        59429    24085    -35344     
- Misses       8109    10797     +2688     
+ Partials      308       58      -250     
Flag Coverage Δ
integrationtests 65.14% <ø> (+0.01%) ⬆️
unittests 87.51% <100.00%> (+0.73%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.24% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.64% <ø> (-12.66%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 87.51% <100.00%> (+0.04%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.09% <ø> (-26.89%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44972f0...3837231. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK added the a:storage issue related to storage service label Apr 10, 2025
@GitHK GitHK marked this pull request as ready for review April 10, 2025 13:31
@GitHK GitHK requested a review from sanderegg as a code owner April 10, 2025 13:31
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering why you did not re-use the function that is already around?

@GitHK GitHK requested a review from sanderegg April 11, 2025 09:34
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed. thanks!

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 22, 2025
@GitHK
Copy link
Contributor Author

GitHK commented Apr 22, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 96bf18b

@sonarqubecloud
Copy link

@mergify mergify bot merged commit 96bf18b into ITISFoundation:master Apr 22, 2025
93 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-resolve-project-and-node-in-exports branch April 22, 2025 12:29
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:storage issue related to storage service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants