Skip to content

🎨 E2E: upgrade timings #7511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

🎨 E2E: upgrade timings #7511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from pathlib import Path
from typing import Any, Final

import arrow
import pytest
from playwright._impl._sync_base import EventContextManager
from playwright.sync_api import (
Expand Down Expand Up @@ -385,7 +386,7 @@ def _check_service_endpoint(


_SOCKET_IO_NODE_PROGRESS_WAITER_MAX_IDLE_TIMEOUT: Final[timedelta] = timedelta(
seconds=30
seconds=60
)


Expand Down Expand Up @@ -580,6 +581,7 @@ def expected_service_running(
is_service_legacy: bool,
assertion_output_folder: Path,
) -> Generator[ServiceRunning, None, None]:
started = arrow.utcnow()
with log_context(
logging.INFO, msg=f"Waiting for node to run. Timeout: {timeout}"
) as ctx:
Expand All @@ -588,17 +590,19 @@ def expected_service_running(
logger=ctx.logger,
)
service_running = ServiceRunning(iframe_locator=None)

with websocket.expect_event("framereceived", waiter, timeout=timeout):
if press_start_button:
_trigger_service_start(page, node_id)

yield service_running
elapsed_time = arrow.utcnow() - started

wait_for_service_endpoint_responding(
node_id,
api_request_context=page.request,
product_url=product_url,
is_legacy_service=is_service_legacy,
timeout=min(timeout - int(elapsed_time.total_seconds() * SECOND), 5 * SECOND),
)
service_running.iframe_locator = page.frame_locator(
f'[osparc-test-id="iframe_{node_id}"]'
Expand All @@ -619,6 +623,7 @@ def wait_for_service_running(
"""NOTE: if the service was already started this will not work as some of the required websocket events will not be emitted again
In which case this will need further adjutment"""

started = arrow.utcnow()
with log_context(
logging.INFO, msg=f"Waiting for node to run. Timeout: {timeout}"
) as ctx:
Expand All @@ -629,12 +634,13 @@ def wait_for_service_running(
with websocket.expect_event("framereceived", waiter, timeout=timeout):
if press_start_button:
_trigger_service_start(page, node_id)

elapsed_time = arrow.utcnow() - started
wait_for_service_endpoint_responding(
node_id,
api_request_context=page.request,
product_url=product_url,
is_legacy_service=is_service_legacy,
timeout=min(timeout - int(elapsed_time.total_seconds() * SECOND), 5 * SECOND),
)
return page.frame_locator(f'[osparc-test-id="iframe_{node_id}"]')

Expand Down
Loading