Skip to content

Conversation

@odeimaiz
Copy link
Member

What do these changes do?

The current wait-for-Run-Optimization doesn't work, either because the expected websocket message doesn't reach the frontend or something else.

In this PR we go back to the wait-to-the-button-go-green approach.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 15, 2025
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 15, 2025
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Apr 15, 2025
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.47%. Comparing base (301f34c) to head (202f512).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7533      +/-   ##
==========================================
- Coverage   87.48%   87.47%   -0.02%     
==========================================
  Files        1742     1742              
  Lines       67432    67432              
  Branches     1144     1144              
==========================================
- Hits        58990    58983       -7     
- Misses       8121     8128       +7     
  Partials      321      321              
Flag Coverage Δ *Carryforward flag
integrationtests 65.22% <ø> (+<0.01%) ⬆️
unittests 86.65% <ø> (-0.02%) ⬇️ Carriedforward from 92e204a

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.91% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.98% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.18% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.65% <ø> (ø)
pkg_settings_library 90.79% <ø> (ø)
pkg_simcore_sdk 85.40% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.26% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.52% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (-0.10%) ⬇️
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.40% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.18% <ø> (+0.16%) ⬆️
storage 87.52% <ø> (-0.04%) ⬇️
webclient ∅ <ø> (∅)
webserver 85.94% <ø> (-0.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301f34c...202f512. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz odeimaiz requested a review from pcrespov April 15, 2025 15:44
@sonarqubecloud
Copy link

@odeimaiz odeimaiz enabled auto-merge (squash) April 16, 2025 10:28
@odeimaiz odeimaiz requested a review from pcrespov April 16, 2025 10:28
@odeimaiz odeimaiz merged commit b4ffe76 into ITISFoundation:master Apr 16, 2025
94 checks passed
@odeimaiz odeimaiz deleted the fix/e2e-tip branch April 16, 2025 10:59
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants