-
Notifications
You must be signed in to change notification settings - Fork 32
✨ web-server RPC: exposes list_my_projects_marked_as_jobs
#7534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ web-server RPC: exposes list_my_projects_marked_as_jobs
#7534
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7534 +/- ##
==========================================
- Coverage 87.47% 87.33% -0.15%
==========================================
Files 1742 1570 -172
Lines 67432 63499 -3933
Branches 1144 910 -234
==========================================
- Hits 58987 55457 -3530
+ Misses 8124 7782 -342
+ Partials 321 260 -61
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
32e2c95 to
b2e6286
Compare
list_my_projects_marked_as_jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
services/web/server/src/simcore_service_webserver/projects/_jobs_repository.py
Show resolved
Hide resolved
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! 💯
|
@giancarloromeo @matusdrobuliak66 any comments on the note? |
0b547a4 to
8cab4ca
Compare
bisgaard-itis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks a lot for the effort
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/webserver/projects.py
Outdated
Show resolved
Hide resolved
…ion and enhance test coverage for job-marked projects
…es and refactoring test cases
…ing for API clarity
8cab4ca to
2f4901c
Compare
|
|
I agree with separation into different packages, but I don't get this:
Why models and exceptions can't live in a separate package as well, installed when needed? |



What do these changes do?
Exposes the
list_my_projects_marked_as_jobsmethod on theweb-serverRPC interface to enable theapi-serverto retrieve a paginated list of all projects marked as jobs.simcore_service_webserver.projects._jobs_servicesimcore_service_webserver.projects._jobs_repositoryprojects._controller.projects_rpcservicelib.rabbitmq.rpc_interfaces.webserver.projectsmodels_library.rpc.webserver.projects(shared)servicelib.rabbitmq.rpc_interfaces.webserver.errors(shared)NOTE: The current organization of RPC interfaces feels fragmented and hard to work with. We should consider restructuring them into dedicated Python packages (e.g.,
webserver-rpc-client,webserver-rest-client) to improve clarity and maintainability. The only inconvenient with the proposed approach is that the client has to be installed in the server in order to share models and exceptions. In any case, we already do that with the current setup.Related issue/s
GET /v0/solvers/-/releases/-/jobs/page#7399How to test
Dev-ops
None