-
Notifications
You must be signed in to change notification settings - Fork 32
✨ Adds filtering for Service Listing in Catalog's RPC API #7537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adds filtering for Service Listing in Catalog's RPC API #7537
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7537 +/- ##
==========================================
+ Coverage 87.39% 87.65% +0.25%
==========================================
Files 1700 1740 +40
Lines 65953 67458 +1505
Branches 1146 1121 -25
==========================================
+ Hits 57642 59130 +1488
- Misses 7990 8020 +30
+ Partials 321 308 -13
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3b3317c to
fbc4d42
Compare
5131891 to
ad692f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
services/catalog/tests/unit/with_dbs/test_repositories.py:556
- [nitpick] Consider seeding the random number generator in _create_fake_release_versions to ensure deterministic fake version generation across test runs, which can improve reproducibility.
def _create_fake_release_versions(num_versions: int) -> set[str]:
aa64014 to
ee7c587
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
packages/models-library/src/models_library/function_services_catalog/_key_labels.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/catalog/services.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/repository/_services_sql.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding these so quickly.
packages/models-library/src/models_library/api_schemas_catalog/services.py
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/repository/_services_sql.py
Outdated
Show resolved
Hide resolved
ee9a679 to
5a177bd
Compare
…_service_release_history functions
…d computational services
… handling in SQL queries
…ex patterns for improved maintainability
f4db708 to
1945d04
Compare
|



What do these changes do?
Introduces a
filters: ServiceListFiltersargument in the listing functions of the catalog RPC API to enable service filtering.catalogrpc-clientfilters: ServiceListFilterstolist_services_paginatedandlist_my_service_history_paginatedcatalogsimcore-serviceapi.rpc)filters: ServiceListFiltersin listing endpointsServiceListFiltersto domain modelServiceFiltersDBpytest_simcore.helpers.catalog_rpc_service)service.catalog_services)filter: ServiceFiltersDBin listing logicrepository.services)filter: ServiceFiltersDBapply_services_filtersin SQLAlchemy queriesRelated issue/s
How to test
Dev-ops