Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Apr 16, 2025

What do these changes do?

  • Add legacy tasks to openapi specs. The old long running tasks (before we had the celery storage worker) were exposed in /tasks in the webserver. I removed them from there when the storage worker was added to our stack. For technical reasons it was needed to keep the old implementation (now in /tasks-legacy) but I didn't include them in the OAS because I felt it would cause confusion (the frontend is really only supposed to know about /tasks). But in ♻️ Use catalog rpc client in api-server #7541 I realized we need to have all endpoints exposed in the OAS because this is used in several places for testing.

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Apr 16, 2025
@bisgaard-itis bisgaard-itis added the bug buggy, it does not work as expected label Apr 16, 2025
@bisgaard-itis bisgaard-itis added this to the Pauwel Kwak milestone Apr 16, 2025
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (eeb6a1c) to head (22db730).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7543      +/-   ##
==========================================
- Coverage   87.47%   84.16%   -3.31%     
==========================================
  Files        1743      682    -1061     
  Lines       67497    32079   -35418     
  Branches     1144      170     -974     
==========================================
- Hits        59040    26999   -32041     
+ Misses       8136     5022    -3114     
+ Partials      321       58     -263     
Flag Coverage Δ
integrationtests 65.24% <ø> (+0.03%) ⬆️
unittests 87.32% <ø> (+0.66%) ⬆️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.24% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.55% <ø> (-12.75%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.98% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb6a1c...22db730. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sonarqubecloud
Copy link

@bisgaard-itis bisgaard-itis merged commit 9a00aa7 into ITISFoundation:master Apr 17, 2025
92 of 94 checks passed
@bisgaard-itis bisgaard-itis deleted the add-legacy-tasks-to-webserver-openapi-specs branch April 17, 2025 09:15
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants