-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Add legacy tasks to webserver openapi specs #7543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add legacy tasks to webserver openapi specs #7543
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7543 +/- ##
==========================================
- Coverage 87.47% 84.16% -3.31%
==========================================
Files 1743 682 -1061
Lines 67497 32079 -35418
Branches 1144 170 -974
==========================================
- Hits 59040 26999 -32041
+ Misses 8136 5022 -3114
+ Partials 321 58 -263
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
|



What do these changes do?
/tasksin the webserver. I removed them from there when the storage worker was added to our stack. For technical reasons it was needed to keep the old implementation (now in/tasks-legacy) but I didn't include them in the OAS because I felt it would cause confusion (the frontend is really only supposed to know about/tasks). But in ♻️ Use catalog rpc client in api-server #7541 I realized we need to have all endpoints exposed in the OAS because this is used in several places for testing.Related issue/s
How to test
Dev-ops checklist