Skip to content

🐛 [Frontend] Disable Autocompletion #7549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

🐛 [Frontend] Disable Autocompletion #7549

merged 2 commits into from
Apr 17, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 17, 2025 •
edited
Loading

What do these changes do?

I can't reproduce it in my local deployment, so this is an attempt to disable the autocompletion in the Dashboards Search tool by setting the autocomplete attribute to off, and the input type from the default text to search.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz marked this pull request as ready for review April 17, 2025 13:31
@odeimaiz odeimaiz self-assigned this Apr 17, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Apr 17, 2025
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 17, 2025
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@odeimaiz odeimaiz enabled auto-merge (squash) April 17, 2025 13:44
@odeimaiz odeimaiz disabled auto-merge April 17, 2025 13:46
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 17, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 17, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 64f94c8

@mergify mergify bot merged commit 64f94c8 into ITISFoundation:master Apr 17, 2025
58 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@alexpargon alexpargon Awaiting requested review from alexpargon

@pcrespov pcrespov Awaiting requested review from pcrespov

@sanderegg sanderegg Awaiting requested review from sanderegg

+1 more reviewer

@capbrown capbrown capbrown approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odeimaiz odeimaiz

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

Do not autocomplete the Search field

4 participants

@odeimaiz @giancarloromeo @capbrown @matusdrobuliak66