Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 21, 2025

What do these changes do?

Compressing and downloading data can be a task that takes time. In order to have persistent export_data tasks, this PR uses the feature implemented in this other PR.

When the user logs in, the active tasks are fetched, if tasks with export_data name are found, these are added to the "cog" button of the background tasks and it will behave the same as the export task would have been initiated in that session: once the data is compressed and the download link is provided, the frontend will download it.

PersistentExport

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 21, 2025
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 21, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Apr 21, 2025
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (6dc3e0b) to head (88e679a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7554      +/-   ##
==========================================
+ Coverage   84.87%   87.42%   +2.55%     
==========================================
  Files        1644     1747     +103     
  Lines       62710    67585    +4875     
  Branches     1146     1146              
==========================================
+ Hits        53227    59089    +5862     
+ Misses       9163     8175     -988     
- Partials      320      321       +1     
Flag Coverage Δ *Carryforward flag
integrationtests 64.05% <ø> (+3.97%) ⬆️
unittests 86.72% <ø> (+2.01%) ⬆️ Carriedforward from 1fd77ea

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.91% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.00% <ø> (-0.02%) ⬇️
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.18% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.96% <ø> (+0.55%) ⬆️
pkg_settings_library 90.84% <ø> (ø)
pkg_simcore_sdk 85.40% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 91.23% <ø> (ø)
autoscaling 96.08% <ø> (∅)
catalog 92.52% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.87% <ø> (ø)
director_v2 91.30% <ø> (+5.77%) ⬆️
dynamic_scheduler 97.40% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.29% <ø> (+0.21%) ⬆️
storage 87.31% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.62% <ø> (+4.88%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc3e0b...88e679a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz odeimaiz marked this pull request as ready for review April 21, 2025 15:06
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 22, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

@sonarqubecloud
Copy link

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8af97e4

@mergify mergify bot merged commit 8af97e4 into ITISFoundation:master Apr 22, 2025
58 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants