Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Apr 22, 2025

What do these changes do?

Fix service_library tests adding the missing AsyncJob's name.

Related issue/s

How to test

cd packages/service-libraries
pytest tests/rabbitmq/test_rabbitmq_rpc_interfaces_async_jobs.py

Dev-ops checklist

@giancarloromeo giancarloromeo added the a:services-library issues on packages/service-libs label Apr 22, 2025
@giancarloromeo giancarloromeo added this to the Pauwel Kwak milestone Apr 22, 2025
@giancarloromeo giancarloromeo self-assigned this Apr 22, 2025
@giancarloromeo giancarloromeo changed the title 🐛 Add missing AsyncJob name 🐛 Add missing AsyncJobs name Apr 22, 2025
@giancarloromeo giancarloromeo changed the title 🐛 Add missing AsyncJobs name 🐛 Add missing AsyncJob's name Apr 22, 2025
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.37%. Comparing base (8af97e4) to head (1c8aa09).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7555      +/-   ##
==========================================
+ Coverage   85.89%   87.37%   +1.47%     
==========================================
  Files        1747     1376     -371     
  Lines       67691    57171   -10520     
  Branches     1146      597     -549     
==========================================
- Hits        58142    49952    -8190     
+ Misses       9229     7033    -2196     
+ Partials      320      186     -134     
Flag Coverage Δ
integrationtests 65.21% <ø> (+0.01%) ⬆️
unittests 86.40% <ø> (+1.53%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.96% <ø> (+0.55%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.40% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 91.23% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.52% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.40% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage 87.64% <ø> (+0.24%) ⬆️
webclient ∅ <ø> (∅)
webserver 86.03% <ø> (+5.42%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af97e4...1c8aa09. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo marked this pull request as ready for review April 22, 2025 08:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the service_library tests by adding the missing job_name parameter to AsyncJobGet in both the list_jobs and submit routines.

  • Modified list_jobs to include a hardcoded job_name.
  • Updated submit to return AsyncJobGet with job_name.
Comments suppressed due to low confidence (2)

packages/service-library/tests/rabbitmq/test_rabbitmq_rpc_interfaces_async_jobs.py:112

  • [nitpick] Consider defining the test job name as a constant instead of a hardcoded string, which could improve consistency and ease future updates in test cases.
job_name="fake_job_name",

packages/service-library/tests/rabbitmq/test_rabbitmq_rpc_interfaces_async_jobs.py:121

  • [nitpick] Consider defining the test job name as a constant for use in both list_jobs and submit methods to enhance maintainability.
return AsyncJobGet(job_id=job_id, job_name="fake_job_name")

@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo added the bug buggy, it does not work as expected label Apr 22, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you find how that made it in?

@giancarloromeo giancarloromeo enabled auto-merge (squash) April 22, 2025 09:20
@giancarloromeo giancarloromeo merged commit e42e1a3 into ITISFoundation:master Apr 22, 2025
94 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
@giancarloromeo giancarloromeo deleted the fix-missing-async-job-name branch May 13, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:services-library issues on packages/service-libs bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants