- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
          🐛 Add missing AsyncJob's name
          #7555
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    🐛 Add missing AsyncJob's name
  
  #7555
              Conversation
AsyncJobs name
      AsyncJobs nameAsyncJob's name
      
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #7555      +/-   ##
==========================================
+ Coverage   85.89%   87.37%   +1.47%     
==========================================
  Files        1747     1376     -371     
  Lines       67691    57171   -10520     
  Branches     1146      597     -549     
==========================================
- Hits        58142    49952    -8190     
+ Misses       9229     7033    -2196     
+ Partials      320      186     -134     
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the service_library tests by adding the missing job_name parameter to AsyncJobGet in both the list_jobs and submit routines.
- Modified list_jobs to include a hardcoded job_name.
 - Updated submit to return AsyncJobGet with job_name.
 
Comments suppressed due to low confidence (2)
packages/service-library/tests/rabbitmq/test_rabbitmq_rpc_interfaces_async_jobs.py:112
- [nitpick] Consider defining the test job name as a constant instead of a hardcoded string, which could improve consistency and ease future updates in test cases.
 
job_name="fake_job_name",
packages/service-library/tests/rabbitmq/test_rabbitmq_rpc_interfaces_async_jobs.py:121
- [nitpick] Consider defining the test job name as a constant for use in both list_jobs and submit methods to enhance maintainability.
 
return AsyncJobGet(job_id=job_id, job_name="fake_job_name")
          
 | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you find how that made it in?



What do these changes do?
Fix
service_librarytests adding the missingAsyncJob's name.Related issue/s
How to test
Dev-ops checklist