- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
          🎨 Extends list_projects_marked_as_jobs in the webserver's rpc API
          #7577
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    🎨 Extends list_projects_marked_as_jobs in the webserver's rpc API
  
  #7577
              Conversation
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #7577      +/-   ##
==========================================
+ Coverage   87.68%   87.73%   +0.05%     
==========================================
  Files        1774     1767       -7     
  Lines       68413    68236     -177     
  Branches     1125     1125              
==========================================
- Hits        59985    59869     -116     
+ Misses       8121     8061      -60     
+ Partials      307      306       -1     
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the webserver’s RPC API schema for job‐based projects by renaming data models and updating the payload to include workbench details. Key changes include:
- Replacing the ProjectRpcGet model with the new ProjectJobRpcGet in tests and API endpoints.
 - Adding and comparing a new workbench property in project payloads.
 - Adjusting timestamp field names and migrating repository queries and RPC interfaces accordingly.
 
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description | 
|---|---|
| tests/unit/with_dbs/02/test_projects_rpc.py | Updated to use ProjectJobRpcGet and added assertions for workbench fields. | 
| tests/unit/with_dbs/02/test_projects__jobs_service.py | Added fixture dependency and further asserts to verify workbench structure. | 
| src/simcore_service_webserver/projects/models.py | Extended ProjectJobDBGet to include workbench data. | 
| src/simcore_service_webserver/projects/_projects_service.py | Added a type ignore on NodeState update; minimal adjustments for RPC jobs. | 
| src/simcore_service_webserver/projects/_controller/projects_rpc.py | Changed return types and model creation to match ProjectJobRpcGet. | 
| packages/* | Updated RPC interfaces and models-library definitions to adopt the new Job RPC models and timestamp field renaming. | 
        
          
                services/web/server/src/simcore_service_webserver/projects/_projects_service.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/models-library/src/models_library/rpc/webserver/projects.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      list_projects_marked_as_jobs in the webserver's rpc API
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
        
          
                packages/pytest-simcore/src/pytest_simcore/helpers/catalog_rpc_server.py
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/projects/_jobs_repository.py
          
            Show resolved
            Hide resolved
        
      …ions and examples
…e ServiceUpdateV2
9415df4    to
    af57c65      
    Compare
  
    | 
           @mergify queue  | 
    
          
 🛑 The pull request has been removed from the queue 
 | 
    
          
 | 
    
| 
           This pull request has been removed from the queue for the following reason:  The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again.  | 
    



What do these changes do?
ProjectJobRpcGetreturnedlist_projects_marked_as_jobsin the webserver's rpc API.Related issue/s
GET /v0/solvers/-/releases/-/jobs/page#7399How to test
Dev-ops
None