🐛Maintenance: Unlock botocore again 🚨🚨🚨🚨 #7589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
bug
sanderegg
changed the title
sanderegg
requested review from
GitHK,
matusdrobuliak66,
mrnicegyu11 and
pcrespov
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7589 +/- ##
==========================================
+ Coverage 87.70% 89.22% +1.52%
==========================================
Files 1774 1245 -529
Lines 68437 52697 -15740
Branches 1126 217 -909
==========================================
- Hits 60021 47020 -13001
+ Misses 8108 5609 -2499
+ Partials 308 68 -240
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
approved these changes
Apr 25, 2025
services/dask-sidecar/src/simcore_service_dask_sidecar/file_utils.py
Outdated
Show resolved
Hide resolved
GitHK
approved these changes
Apr 25, 2025
sanderegg
force-pushed
the
maintenance/unlock-botocore-again
branch
from
251a7fb to
e4dafa7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request includes updates to the AWS S3 client library and related dependencies, along with refactoring and cleanup of the codebase. The changes primarily focus on removing outdated compatibility checks, upgrading dependencies, and improving code readability and maintainability.
This should allow using the latest botocore library with our current CEPH S3.
Dependency Updates and Compatibility Changes:
botocoreto version1.37.1andaiobotocoreto version2.21.1, removing constraints on older versions that were required for CEPH S3 compatibility. [1] [2] [3] [4]s3transferto version0.11.3andboto3to version1.37.1across multiple services. [1] [2] [3]Code Cleanup and Refactoring:
_check_botocore_versionfunction and related warnings about botocore compatibility with CEPH S3. [1] [2] [3] [4]warnings,version, andbotocore_versionfroms3/_client.py. [1] [2] [3]Functional Enhancements:
request_checksum_calculation="when_required"to the S3 client configuration to ensure checksum calculations are performed when needed. [1] [2]_copy_filefunction by refactoring thefsspec.opencontext manager for better readability.Packaging and Dependency Management:
These changes collectively modernize the codebase, improve maintainability, and ensure compatibility with the latest versions of AWS-related libraries.
Related issue/s
How to test
Dev-ops checklist