Skip to content

🐛 [Frontend] Fix: Shared with Everyone filter #7596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 5, 2025
Merged

🐛 [Frontend] Fix: Shared with Everyone filter #7596

merged 10 commits into from
May 5, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 28, 2025 •
edited
Loading

What do these changes do?

  • Fix filter
  • Reword to "Public {{resource_type}}"

Buggy:
SharedWithEveryone_bug

Fixed:
SharedWithEveryone

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 28, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Apr 28, 2025
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 28, 2025
@odeimaiz odeimaiz marked this pull request as ready for review April 28, 2025 09:58
sanderegg
sanderegg reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

pcrespov
pcrespov reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 28, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 28, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit 21fce72 into ITISFoundation:master May 5, 2025
58 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@odeimaiz odeimaiz

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

6 participants

@odeimaiz @giancarloromeo @GitHK @pcrespov @sanderegg @matusdrobuliak66